Conversation
Fixed some race conditions resulting in infinite redirects. Idk why this was working on web but not on desktop tho...
Analysis Report for c98a593
Click to see the full report |
Analysis Report for c98a593
Click to see the full report |
Analysis Report for 3498527
Click to see the full report |
mcquenji
changed the title
Analysis Report for 3498527
Click to see the full report |
RiedleroD
suggested changes
Mar 14, 2025
Contributor
RiedleroD
left a comment
RiedleroD
left a comment
There was a problem hiding this comment.
it does this when I try to log into our test moodle server; pressing on "return to home" opens the correct page incl. "beta test" popup
Analysis Report for ab60f94
Click to see the full report |
Contributor
|
when clicking on calendar view, it throws me into settings (what?) |
Contributor
Author
|
unreleated to this PR |
RiedleroD
approved these changes
Mar 15, 2025
Contributor
RiedleroD
left a comment
RiedleroD
left a comment
There was a problem hiding this comment.
well ok then I guess it works
MasterMarcoHD
approved these changes
Mar 21, 2025
Contributor
MasterMarcoHD
left a comment
MasterMarcoHD
left a comment
There was a problem hiding this comment.
Works on Arch WSL with no issues.
Analysis Report for ab60f94
Click to see the full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several enhancements and bug fixes primarily focused on improving the authentication and authorization mechanisms, as well as optimizing repository refresh operations.
Authentication and Authorization Enhancements:
AuthGuardandCapabilityGuardto provide better insights into authentication and capability checks (lib/src/auth/presentation/guards/auth_guard.dart,lib/src/auth/presentation/guards/capability_guard.dart) [1] [2].AuthRepositoryto return a boolean on authentication success and added arequireAuthmethod to ensure the user is authenticated (lib/src/auth/presentation/repositories/auth_repository.dart) [1] [2].LoginScreenandLoginFormto handle successful login via a callback (lib/src/auth/presentation/screens/login_screen.dart,lib/src/auth/presentation/widgets/login_form.dart) [1] [2].Repository Refresh Optimization:
buildmethod calls withrefreshin various repository classes to improve data consistency and performance (lib/src/calendar/presentation/repositories/calendar_plan_repository.dart,lib/src/calendar/presentation/repositories/invites_repository.dart,lib/src/moodle/presentation/guards/has_courses_guard.dart,lib/src/slots/presentation/repositories/slot_master_slots_repository.dart,lib/src/slots/presentation/repositories/slots_repository.dart) [1] [2] [3] [4] [5].Other Notable Changes:
AppModuleto ensure proper access control and avoiding infinite redirects (lib/src/app/app.dart) [1] [2] [3].CapabilityGuard(lib/src/auth/presentation/guards/capability_guard.dart).UserRepositoryto check for authentication state directly and improve user data handling (lib/src/auth/presentation/repositories/user_repository.dart) [1] [2].